[python-dateutil] Add missing stubs #14326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
donBarbos
commented
Jun 22, 2025
donBarbos
commented
- Fix and improve few stubs
* Fix and improve few stubs
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
srittau
requested changes
Jul 7, 2025
| freq, | ||
| dtstart: datetime.date | None = None, | ||
| freq: Literal[0, 1, 2, 3, 4, 5, 6], | ||
| dtstart: datetime.datetime | None = None, |
There was a problem hiding this comment.
The old annotation was correct. rrule converts a date to a datetime:
I'd also be fine with using datetime.datetime | datetime.date. Although technically redundant, it's a bit clearer. (Also deriving datetime from date was a mistake, in my opinion.)
See also the prefect primer hits.
| self, | ||
| s: str, | ||
| *, | ||
| dtstart: datetime.datetime | None = None, |
There was a problem hiding this comment.
Suggested change
| dtstart: datetime.datetime | None = None, | |
| dtstart: datetime.date | None = None, |
See above.
|
The homeassistant primer hit is a bit unfortunate, but can easily be worked around with an explicit type annotation for the constant dict. |
|
Huh, new pyright errors. They seem legit, but strange that they're only appearing now. Probably due to a newer pyright version. |
srittau
approved these changes
Jul 7, 2025
|
Diff from mypy_primer, showing the effect of this PR on open source code: core (https://github.com/home-assistant/core)
+ homeassistant/components/habitica/util.py:81: error: Argument "freq" to "rrule" has incompatible type "int"; expected "Literal[0, 1, 2, 3, 4, 5, 6]" [arg-type]
prefect (https://github.com/PrefectHQ/prefect)
+ src/prefect/client/schemas/schedules.py:290: error: Argument 1 to "append" of "list" has incompatible type "rrule"; expected "rruleset" [arg-type]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.